r90877 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90876‎ | r90877 | r90878 >
Date:14:05, 27 June 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Follow-up r86044 CR (correct subtitle message for action=credits), and some documentation.
Modified paths:
  • /trunk/phase3/includes/actions/CreditsAction.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/actions/CreditsAction.php
@@ -33,8 +33,14 @@
3434 return null;
3535 }
3636
 37+ protected function getDescription() {
 38+ return wfMsg( strtolower( 'creditspage' ) );
 39+ }
 40+
3741 /**
3842 * This is largely cadged from PageHistory::history
 43+ *
 44+ * @return String HTML
3945 */
4046 public function onView() {
4147 wfProfileIn( __METHOD__ );
@@ -75,6 +81,7 @@
7682 /**
7783 * Get the last author with the last modification time
7884 * @param $article Article object
 85+ * @return String HTML
7986 */
8087 protected static function getAuthor( Article $article ) {
8188 global $wgLang;
@@ -94,7 +101,6 @@
95102
96103 /**
97104 * Get a list of contributors of $article
98 - * @param $article Article object
99105 * @param $cnt Int: maximum list of contributors to show
100106 * @param $showIfMax Bool: whether to contributors if there more than $cnt
101107 * @return String: html

Follow-up revisions

RevisionCommit summaryAuthorDate
r90885Follow-up r90877: spot the copy-and-pasted code... :Dhappy-melon16:22, 27 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86044Follow-up r 86041 per CR and IRC:...happy-melon12:17, 14 April 2011

Comments

#Comment by Nikerabbit (talk | contribs)   16:19, 27 June 2011

What do you think strtolower( 'creditspage' ) will return?

Status & tagging log