r90864 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90863‎ | r90864 | r90865 >
Date:23:39, 26 June 2011
Author:robin
Status:deferred (Comments)
Tags:
Comment:
Babel CSS: follow the content direction instead of the user language direction (support for $wgBetterDirectionality)
Modified paths:
  • /trunk/extensions/Babel/Babel.css (modified) (history)

Diff [purge]

Index: trunk/extensions/Babel/Babel.css
@@ -10,10 +10,10 @@
1111 */
1212
1313 /* Babel wrapper layout. */
14 -table.mw-babel-wrapper {
 14+/* @noflip */table.mw-babel-wrapper {
1515 width: 238px;
16 - float: right;
17 - clear: right;
 16+ float: right; /* change this to 'left' on RTL wikis */
 17+ clear: right; /* change this to 'left' on RTL wikis */
1818 margin: 1em;
1919 background-color: white;
2020 border-style: solid;
@@ -22,9 +22,9 @@
2323 }
2424
2525 /* Babel box layout */
26 -div.mw-babel-box {
27 - float: left;
28 - clear: left;
 26+/* @noflip */div.mw-babel-box {
 27+ float: left; /* change this to 'right' on RTL wikis */
 28+ clear: left; /* change this to 'right' on RTL wikis */
2929 margin: 1px;
3030 }
3131

Comments

#Comment by Nikerabbit (talk | contribs)   18:49, 28 June 2011

Why is this file not just loaded through resource loader like everything else?

#Comment by SPQRobin (talk | contribs)   12:14, 30 June 2011

I agree. (However, then it would need a different solution, because left/right depends on the content language.)

Status & tagging log