r90851 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90850‎ | r90851 | r90852 >
Date:20:00, 26 June 2011
Author:mah
Status:ok
Tags:
Comment:
Followup r90239: Move return till after the toggle is executed.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.makeCollapsible.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.makeCollapsible.js
@@ -176,10 +176,10 @@
177177 },
178178 // Toggles collapsible and togglelink class
179179 toggleLinkPremade = function( $that, e ) {
 180+ var $collapsible = $that.eq(0).closest( '.mw-collapsible.mw-made-collapsible' ).toggleClass( 'mw-collapsed' );
180181 if ( $(e.target).is('a') ) {
181182 return true;
182183 }
183 - var $collapsible = $that.eq(0).closest( '.mw-collapsible.mw-made-collapsible' ).toggleClass( 'mw-collapsed' );
184184 e.preventDefault();
185185 e.stopPropagation();
186186

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90239Fix Bug #28344 - “Links doesn't work inside collapsible toggles”...mah22:27, 16 June 2011

Status & tagging log