r90839 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90838‎ | r90839 | r90840 >
Date:17:36, 26 June 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Followup r90775: Fix PHP Notice: Undefined index: deletedonly in /www/w/includes/specials/SpecialContributions.php on line 131
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
——@@ -128,8 +128,8 @@
129129 if ( $this->opts['showSizeDiff'] ) {
130130 $apiParams['showsizediff'] = true;
131131 }
132 - if ( $this->opts['deletedonly'] ) {
133 - $apiParams['deletedonly'] = true;
 132+ if ( $this->opts['deletedOnly'] ) {
 133+ $apiParams['deletedOnly'] = true;
134134 }
135135 if ( $this->opts['tagFilter'] !== '' ) {
136136 $apiParams['tagfilter'] = $this->opts['tagFilter'];

Follow-up revisions

RevisionCommit summaryAuthorDate
r90844Followup r90839, de-capitali[sz]e api parameterreedy19:20, 26 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90775Followup r89566...reedy16:41, 25 June 2011

Comments

#Comment by Reedy (talk | contribs)   17:45, 26 June 2011

Cheers Raymond

#Comment by Duplicatebug (talk | contribs)   19:04, 26 June 2011

api params always lowercase: changing $apiParams['deletedonly'] = true; is wrong

Status & tagging log