r90812 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90811‎ | r90812 | r90813 >
Date:02:05, 26 June 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Removing console.log and other ad-hoc debugging code
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
@@ -80,14 +80,6 @@
8181 debug: false
8282 };
8383
84 - /* debuging utils */
85 - //
86 - // function benchmark( s, d ) {
87 - // console.log( s + " " + ( new Date().getTime() - d.getTime() ) + "ms" );
88 - // }
89 - //
90 - // this.benchmark = benchmark;
91 - //
9284 /* parsers utils */
9385
9486 function buildParserCache( table, $headers ) {
@@ -110,9 +102,7 @@
111103 if (p === false) {
112104 p = detectParserForColumn( table, rows, i );
113105 }
114 - // if ( table.config.debug ) {
115 - // console.log( "column:" + i + " parser:" + p.id + "\n" );
116 - // }
 106+
117107 list.push(p);
118108 }
119109 }
@@ -299,11 +289,6 @@
300290 table.config.headerList[index] = this;
301291 } );
302292
303 - // if ( table.config.debug ) {
304 - // benchmark( "Built headers:", time );
305 - // console.log( $tableHeaders );
306 - // }
307 - //
308293 return $tableHeaders;
309294
310295 }
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.history.js
@@ -59,7 +59,6 @@
6060 }
6161 var copyAttrs = ['title', 'accesskey'];
6262 $buttons.each(function() {
63 - console.log(this);
6463 var $button = $(this),
6564 $compareLink= $( '<a></a>', {
6665 'class': 'compare-link',

Follow-up revisions

RevisionCommit summaryAuthorDate
r91782MFT to REL_1_18: jquery tablesorter...hashar08:54, 9 July 2011

Comments

#Comment by Hashar (talk | contribs)   08:56, 9 July 2011

mediawiki.action.history not merged in 1.18 :b

Status & tagging log