r90806 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90805‎ | r90806 | r90807 >
Date:00:38, 26 June 2011
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
switching to blue hearts per discussion
Modified paths:
  • /trunk/extensions/WikiLove/modules/ext.wikiLove/images/heart-icons.png (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/modules/ext.wikiLove/images/heart-icons.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png

Follow-up revisions

RevisionCommit summaryAuthorDate
r90821disambiguting file namekaldari05:23, 26 June 2011
r90822switching back to red icons per popular demandkaldari05:23, 26 June 2011

Comments

#Comment by Jorm (WMF) (talk | contribs)   04:45, 26 June 2011

I don't like this. The red is far better than the blue.

Was this discussion on-wiki?

I am marking this "fixme".

#Comment by P858snake (talk | contribs)   04:47, 26 June 2011

Well we should try to reduce the use of red where possible because red typically = error. Also Blues and yellows are much better colours because of the lowest risk of getting someone with colour blindness.

#Comment by Jorm (WMF) (talk | contribs)   04:49, 26 June 2011

I think there is very little chance of someone mis-understanding a red heart as an error in this case.

Yellows are *exceedingly* bad colors for anything on the web in most cases, and blues. . . well. Wikipedia is already far, far too blue. And blue hearts = broken and sad. So let's go back to the red ones.

#Comment by Aaron Schulz (talk | contribs)   04:51, 26 June 2011

I'd agree that people likely won't see a red heart and thing "zomg error!".

#Comment by Bawolff (talk | contribs)   04:48, 26 June 2011

Don't you know, Wiki editors are cold hearted people - thus the blue ;)

#Comment by Kaldari (talk | contribs)   05:29, 26 June 2011

OK, I've reverted it by popular demand. Even Erik didn't like it. I'm keeping the blue versions checked in, just in case :)

Status & tagging log