r90800 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90799‎ | r90800 | r90801 >
Date:21:28, 25 June 2011
Author:bawolff
Status:deferred
Tags:
Comment:
(Follow up r90760) fix comment about mw version required and fix getFirstLetter method to work on prefix not actual sortkey.
Modified paths:
  • /trunk/extensions/CategorySortHeaders/CategorySortHeaders.php (modified) (history)
  • /trunk/extensions/CategorySortHeaders/CategorySortHeaders_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategorySortHeaders/CategorySortHeaders_body.php
@@ -49,7 +49,7 @@
5050 }
5151
5252 $m = array();
53 - if ( preg_match( '/^[^\n^]*\^([^\n^]*)\^/', $string, $m ) ) {
 53+ if ( preg_match( '/^\^([^\n^]*)\^/', $string, $m ) ) {
5454 return $m[1];
5555 } else {
5656 // Probably shouldn't happen.
Index: trunk/extensions/CategorySortHeaders/CategorySortHeaders.php
@@ -11,7 +11,7 @@
1212 * in LocalSettings.php. It defines its own Collation that is
1313 * roughly equivalent to 'uppercase', and thus can't be used
1414 * with 'uca-default' or any other custom collation.
15 - * Additionally, this extension requires at least MediaWiki 1.17.
 15+ * Additionally, this extension requires at least MediaWiki 1.19.
1616 *
1717 * To install:
1818 * Add to the bottom of LocalSettings.php:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90760New extension: CategorySortHeaders, to make custom headers instead of just th...bawolff07:27, 25 June 2011

Status & tagging log