r90738 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r90737
|
r90738
|
r90739
>
Date:
21:36, 24 June 2011
Author:
bawolff
Status:
ok
Tags:
Comment:
follow-up
r90737
- also normalize 'createtalk' for good measure.
Note, atm not such a big deal as there are no direct uses of 'createtalk' permission
but good to check for potential future bugs.
Modified paths:
/trunk/extensions/TitleBlacklist/TitleBlacklist.hooks.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/TitleBlacklist/TitleBlacklist.hooks.php
—
—
@@ -29,7 +29,7 @@
30
30
# Some places check createpage, while others check create.
31
31
# As it stands, upload does createpage, but normalize both
32
32
# to the same action, to stop future similar bugs.
33
- if( $action === 'createpage' ) {
33
+ if( $action === 'createpage' || $action === 'createtalk' ) {
34
34
$action = 'create';
35
35
}
36
36
if( $action == 'create' || $action == 'edit' || $action == 'upload' ) {
Follow-up revisions
Revision
Commit summary
Author
Date
r92265
MFT
r90737
,
r90738
to 1.17wmf1, REL1_18
reedy
18:20, 15 July 2011
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r90737
(
bug 28466
) Make titleblack list consider 'createpage' action to be same as '...
bawolff
21:25, 24 June 2011
Status & tagging log
18:20, 15 July 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r90738
[
removed:
1.17wmf1,1.18]
18:13, 15 July 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r90738
[
added:
1.18]
18:12, 15 July 2011
Reedy
(
talk
|
contribs
)
changed the
tags
for r90738
[
added:
1.17wmf1]
22:40, 24 June 2011
Aaron Schulz
(
talk
|
contribs
)
changed the
status
of r90738
[
removed:
new
added:
ok]