r90735 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90734‎ | r90735 | r90736 >
Date:20:59, 24 June 2011
Author:robin
Status:ok (Comments)
Tags:
Comment:
(bug 28030) LTR usernames are aligned incorrectly in RTL wikis when the date preference is yyyy-mm-ddThh:mm:ss -> add a direction mark
Modified paths:
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HistoryPage.php
——@@ -535,6 +535,7 @@
536536 }
537537
538538 $s .= " $link";
 539+ $s .= wfUILang()->getDirMark();
539540 $s .= " <span class='history-user'>" .
540541 $this->getSkin()->revUserTools( $rev, true ) . "</span>";
541542

Follow-up revisions

RevisionCommit summaryAuthorDate
r91315* Add release notes for my recent commits (bug 6100 and others like bugs 2803...robin22:50, 1 July 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   22:53, 15 August 2011

It be nice to mention the bug number as a code comment.

#Comment by SPQRobin (talk | contribs)   23:23, 15 August 2011

Why? I did mention the bug number in the commit summary.

Status & tagging log