r90688 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90687‎ | r90688 | r90689 >
Date:01:08, 24 June 2011
Author:neilk
Status:ok (Comments)
Tags:upstream 
Comment:
linted jpegmeta - commas cause IE errors. Not that this library is useful on IE, but it can cause errors just by being loaded
Modified paths:
  • /trunk/phase3/resources/mediawiki.libs/mediawiki.libs.jpegmeta.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki.libs/mediawiki.libs.jpegmeta.js
@@ -118,7 +118,7 @@
119119 /* Rational number methods */
120120 JpegMeta.Rational.prototype.toString = function toString() {
121121 if (this.num === 0) {
122 - return "" + this.num
 122+ return "" + this.num;
123123 }
124124 if (this.den === 1) {
125125 return "" + this.num;
@@ -291,7 +291,7 @@
292292 9 : ["SLONG", 4],
293293 10 : ["SRATIONAL", 8],
294294 11 : ["FLOAT", 4],
295 - 12 : ["DOUBLE", 8],
 295+ 12 : ["DOUBLE", 8]
296296 };
297297
298298 this.JpegMeta.JpegFile.prototype._tifftags = {
@@ -308,7 +308,7 @@
309309 {1 : "Normal", 2 : "Reverse?",
310310 3 : "Upside-down", 4 : "Upside-down Reverse",
311311 5 : "90 degree CW", 6 : "90 degree CW reverse",
312 - 7 : "90 degree CCW", 8 : "90 degree CCW reverse",}],
 312+ 7 : "90 degree CCW", 8 : "90 degree CCW reverse"}],
313313 277 : ["Number of components", "SamplesPerPixel"],
314314 284 : ["Image data arrangement", "PlanarConfiguration",
315315 {1 : "chunky format", 2 : "planar format"}],
@@ -342,7 +342,7 @@
343343 33432 : ["Copyright holder", "Copyright"],
344344
345345 34665 : ["Exif tag", "ExifIfdPointer"],
346 - 34853 : ["GPS tag", "GPSInfoIfdPointer"],
 346+ 34853 : ["GPS tag", "GPSInfoIfdPointer"]
347347 };
348348
349349 this.JpegMeta.JpegFile.prototype._exiftags = {
@@ -418,7 +418,7 @@
419419 /* H. Other Tags */
420420 42016 : ["Unique image ID", "ImageUniqueID"],
421421
422 - 40965 : ["Interoperability tag", "InteroperabilityIFDPointer"],
 422+ 40965 : ["Interoperability tag", "InteroperabilityIFDPointer"]
423423 };
424424
425425 this.JpegMeta.JpegFile.prototype._gpstags = {
@@ -453,7 +453,7 @@
454454 27 : ["Name of GPS processing method", "GPSProcessingMethod"],
455455 28 : ["Name of GPS area", "GPSAreaInformation"],
456456 29 : ["GPS Date", "GPSDateStamp"],
457 - 30 : ["GPS differential correction", "GPSDifferential"],
 457+ 30 : ["GPS differential correction", "GPSDifferential"]
458458 };
459459
460460 this.JpegMeta.JpegFile.prototype._markers = {
@@ -535,7 +535,7 @@
536536 0xfe: ["COM", null], /* Comment */
537537
538538 /* Reserved markers */
539 - 0x01: ["JPG13", null], /* For temporary private use in arithmetic coding */
 539+ 0x01: ["JPG13", null] /* For temporary private use in arithmetic coding */
540540 /* 02 -> bf are reserverd */
541541 };
542542
@@ -728,4 +728,4 @@
729729 return new JpegMeta.JpegFile( fileReaderResult, fileName );
730730 };
731731
732 -} )( jQuery );
\ No newline at end of file
 732+} )( jQuery );

Comments

#Comment by Krinkle (talk | contribs)   01:16, 25 June 2011

Upstream as well ?

#Comment by NeilK (talk | contribs)   01:17, 25 June 2011

you can't let me be lazy for once?! yeah, okay :)

Status & tagging log