r90667 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90666‎ | r90667 | r90668 >
Date:17:20, 23 June 2011
Author:hartman
Status:ok (Comments)
Tags:
Comment:
Set window.wgMonthNamesShort before we start the tests, to be able to pass added-globals detection.

Follow up to r90655
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.tablesorter.test.js
@@ -5,6 +5,7 @@
66 // setup hack
77 mw.config.set('wgMonthNames', window.wgMonthNames = ['', 'January', 'February', 'March', 'April', 'May', 'June', 'July', 'August', 'September', 'October', 'November', 'December']);
88 mw.config.set('wgMonthNamesShort', window.wgMonthNamesShort = ['', 'Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']);
 9+mw.config.set('wgDefaultDateFormat', window.wgDefaultDateFormat = 'dmy');
910
1011 test( '-- Initial check', function() {
1112 expect(1);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90655Adding a collation test to tablesorter, fixing var ref from r90630diebuche07:39, 23 June 2011

Comments

#Comment by Hashar (talk | contribs)   15:05, 18 July 2011

qunit tests are not going to be shipped with 1.18. Removing tag.

Status & tagging log