r90626 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90625‎ | r90626 | r90627 >
Date:23:03, 22 June 2011
Author:diebuche
Status:ok (Comments)
Tags:
Comment:
Tablesorter: Remove not really necessary setTimeout.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
@@ -579,14 +579,14 @@
580580 config.sortList.push( [i, this.order] );
581581 }
582582 }
583 - setTimeout( function () {
584 - // set css for headers
585 - setHeadersCss( $this[0], $headers, config.sortList, sortCSS, sortMsg );
586 - appendToTable(
587 - $this[0], multisort(
588 - $this[0], config.sortList, cache ) );
589 - //benchmark( "Sorting " + totalRows + " rows:", clickTime );
590 - }, 1 );
 583+
 584+ // set css for headers
 585+ setHeadersCss( $this[0], $headers, config.sortList, sortCSS, sortMsg );
 586+ appendToTable(
 587+ $this[0], multisort(
 588+ $this[0], config.sortList, cache ) );
 589+ //benchmark( "Sorting " + totalRows + " rows:", clickTime );
 590+
591591 // stop normal event by returning false
592592 return false;
593593 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r90635Followup r90595, r90626: remove async magic from table sorter tests now that ...brion23:47, 22 June 2011
r91782MFT to REL_1_18: jquery tablesorter...hashar08:54, 9 July 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   00:12, 23 June 2011

Doesn't seem to have any problems; since the rest of the operation isn't async and we don't need to ping something in UI first it seems just fine! Makes test cases simpler in r90635 too. :)

Status & tagging log