r90524 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90523‎ | r90524 | r90525 >
Date:13:38, 21 June 2011
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
follow up to r90521
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
——@@ -2505,6 +2505,12 @@
25062506 array( ),
25072507 '_CONC'
25082508 );
 2509+
 2510+ self::$prop_tables['smw_coords'] = new SMWSQLStore2Table(
 2511+ 'sm_coords',
 2512+ array( 'lat' => 'f', 'lon' => 'f' ),
 2513+ array( 'lat', 'lon' )
 2514+ );
25092515
25102516 wfRunHooks( 'SMWPropertyTables', array( &self::$prop_tables ) );
25112517

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90521rem coordinate table init code since SMW now handles this stuffjeroendedauw11:45, 21 June 2011

Comments

#Comment by Devayon (talk | contribs)   14:44, 26 June 2011

Hi, I get a database error if I go to index.php directly. Problem is solved (as in I get a proper redirect to main-page) if this patch is reverted. Can you confirm if it's a real bug?

#Comment by Jeroen De Dauw (talk | contribs)   16:24, 26 June 2011

You need to run the table update script at special smwadmin

#Comment by Devayon (talk | contribs)   17:04, 26 June 2011

oh, thanks :)

#Comment by F.trott (talk | contribs)   11:21, 29 June 2011

+ 'sm_coords',

There is probably no functional difference, but should this be smw_coords?

#Comment by Jeroen De Dauw (talk | contribs)   11:43, 29 June 2011

I actually discussed that particular question with Markus. Ideally it should be, but it introduces extra upgrade headaches. SMW is supposed to drop non-used tables, but for some reason it doesn't, so if you rename it, you'd also end up with an obsolete copy. If the name is changed, this should be taken care of first.