r90406 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90405‎ | r90406 | r90407 >
Date:17:38, 19 June 2011
Author:demon
Status:resolved
Tags:
Comment:
Fix up a couple of uses of context->object instead of context->getObject(). Fixes bug 29491
Modified paths:
  • /trunk/phase3/includes/Action.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Action.php
@@ -107,7 +107,7 @@
108108 * @return WebRequest
109109 */
110110 protected final function getRequest() {
111 - return $this->getContext()->request;
 111+ return $this->getContext()->getRequest();
112112 }
113113
114114 /**
@@ -116,7 +116,7 @@
117117 * @return OutputPage
118118 */
119119 protected final function getOutput() {
120 - return $this->getContext()->output;
 120+ return $this->getContext()->getOutput();
121121 }
122122
123123 /**
@@ -125,7 +125,7 @@
126126 * @return User
127127 */
128128 protected final function getUser() {
129 - return $this->getContext()->user;
 129+ return $this->getContext()->getOutput();
130130 }
131131
132132 /**
@@ -134,7 +134,7 @@
135135 * @return Skin
136136 */
137137 protected final function getSkin() {
138 - return $this->getContext()->skin;
 138+ return $this->getContext()->getSkin();
139139 }
140140
141141 /**
@@ -143,7 +143,7 @@
144144 * @return Skin
145145 */
146146 protected final function getLang() {
147 - return $this->getContext()->lang;
 147+ return $this->getContext()->getLang();
148148 }
149149
150150 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r90440Fix for r90406: giving an OutputPage object instead of an User object is not ...ialex08:07, 20 June 2011

Status & tagging log