r90394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90393‎ | r90394 | r90395 >
Date:13:15, 19 June 2011
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Make $I18N->loadTextdomainFromFile of a missing file a lower error (it used to give a Intuition fatal because $messages was then not found).
Modified paths:
  • /trunk/tools/ToolserverI18N/TsIntuition.php (modified) (history)

Diff [purge]

Index: trunk/tools/ToolserverI18N/TsIntuition.php
@@ -651,8 +651,13 @@
652652 }
653653
654654 // Load it
655 - include( $filePath );
656 -
 655+ $included = include( $filePath );
 656+
 657+ if ( $included === false ) {
 658+ $this->errTrigger( "File $filePath could not be loaded ", __METHOD__, E_NOTICE, __FILE__, __LINE__ );
 659+ return false;
 660+ }
 661+
657662 // Parse it
658663 $compact = compact( $this->includeVariables );
659664 $this->parseTextdomain( $compact, $domain, $filePath );

Comments

#Comment by Krinkle (talk | contribs)   01:30, 25 June 2011

Thx, Intuition deployment has been synched up to HEAD.

Status & tagging log