r90371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90370‎ | r90371 | r90372 >
Date:21:57, 18 June 2011
Author:mgrabovsky
Status:resolved (Comments)
Tags:
Comment:
(bug 29437) Multiple apostrophes in deleted article title cause odd rendering

Fixed by wrapping the username in corresponding messages in <nowiki>
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
——@@ -100,6 +100,7 @@
101101 * (bug 29443) Special:Undelete should use JavaScript to invert all checkboxes
102102 without reloading the page
103103 * (bug 29325) Setting $wgStrictFileExtensions to false gives incorrect warning
 104+* (bug 29437) Multiple apostrophes in deleted article title cause odd rendering
104105
105106 === API changes in 1.19 ===
106107 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/languages/messages/MessagesEn.php
——@@ -1320,9 +1320,9 @@
13211321 You can [[Special:Search/{{PAGENAME}}|search for this page title]] in other pages,
13221322 or <span class="plainlinks">[{{fullurl:{{#Special:Log}}|page={{FULLPAGENAMEE}}}} search the related logs]</span>.',
13231323 'noarticletextanon' => '{{int:noarticletext}}', # do not translate or duplicate this message to other languages
1324 -'userpage-userdoesnotexist' => 'User account "$1" is not registered.
 1324+'userpage-userdoesnotexist' => 'User account "<nowiki>$1</nowiki>" is not registered.
13251325 Please check if you want to create/edit this page.',
1326 -'userpage-userdoesnotexist-view' => 'User account "$1" is not registered.',
 1326+'userpage-userdoesnotexist-view' => 'User account "<nowiki>$1</nowiki>" is not registered.',
13271327 'blocked-notice-logextract' => 'This user is currently blocked.
13281328 The latest block log entry is provided below for reference:',
13291329 'clearyourcache' => "'''Note: After saving, you may have to bypass your browser's cache to see the changes.'''

Follow-up revisions

RevisionCommit summaryAuthorDate
r90482Follow-up r90371, per comment by ^demon...mgrabovsky19:45, 20 June 2011

Comments

#Comment by 😂 (talk | contribs)   18:31, 19 June 2011

This is not a good fix since a wiki not having the <nowiki>tag would still be hit by the issue--such as any wiki that's already customized this message. Really the users of these message (Article and EditPage) should be fixed to not parse all markup, perhaps just parsemag.

#Comment by 😂 (talk | contribs)   18:34, 19 June 2011

Stupid, stupid CR comment parsing. Should've said "not having the <nowiki> tag"

#Comment by Matěj Grabovský (talk | contribs)   18:40, 19 June 2011

This also came through my head, but as <nowiki> is already used in deletedtext I have chosen it.

To get rid of the <nowiki>, we could use wfEscapeWikiText() in Article::showMissingArticle(), EditPage::showIntro(), DeleteAction::onSuccess(), etc.

#Comment by 😂 (talk | contribs)   18:42, 19 June 2011

I like the second idea better.

#Comment by Duplicatebug (talk | contribs)   20:13, 20 June 2011

There is also MediaWiki:Welcomecreation with this problem.

#Comment by Duplicatebug (talk | contribs)   19:27, 2 July 2011

Done with r90588 (not in the follow up for this revision)

Status & tagging log