r90289 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r90288‎ | r90289 | r90290 >
Date:16:28, 17 June 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Swap else if for elseif

Trimming trailing whitespace also

last one! ;)
Modified paths:
  • /trunk/extensions/SMWWriter/api/SMWWriter.php (modified) (history)
  • /trunk/extensions/SemanticTasks/SemanticTasks.classes.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/includes/SWL_PropertyChange.php (modified) (history)
  • /trunk/extensions/SignDocument/SpecialSignDocument.php (modified) (history)
  • /trunk/extensions/SlippyMap/SlippyMap.class.php (modified) (history)
  • /trunk/extensions/SmoothGallery/SmoothGalleryClass.php (modified) (history)
  • /trunk/extensions/SmoothGallery/SmoothGalleryParser.php (modified) (history)
  • /trunk/extensions/SpamRegex/SpecialSpamRegex.php (modified) (history)
  • /trunk/extensions/SpecialFileList/SpecialFilelist.php (modified) (history)
  • /trunk/extensions/Storyboard/specials/Story/Story_body.php (modified) (history)
  • /trunk/extensions/StrategyWiki/ActiveStrategy/ActiveStrategy_body.php (modified) (history)
  • /trunk/extensions/SubPageList3/SubPageList3.php (modified) (history)
  • /trunk/extensions/Tasks/Tasks.body.php (modified) (history)
  • /trunk/extensions/TemplateAdventures/Templates/Citation.php (modified) (history)
  • /trunk/extensions/TemplateAdventures/Templates/CitationStyleWiki.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php (modified) (history)
  • /trunk/extensions/TorBlock/TorBlock.class.php (modified) (history)
  • /trunk/extensions/TradeTrack/SpecialTradeTrack.php (modified) (history)
  • /trunk/extensions/Translate/groups/StatusNet/genStatusNet-plugins.php (modified) (history)
  • /trunk/extensions/Translate/spyc/spyc.php (modified) (history)
  • /trunk/extensions/Transliterator/Transliterator_body.php (modified) (history)
  • /trunk/extensions/UKGeocodingForMaps/ParserFunctions/DisplayUkPoint/UKG_DisplayUkPoint.php (modified) (history)
  • /trunk/extensions/UsageStatistics/UsageStatistics_body.php (modified) (history)
  • /trunk/extensions/Validator/includes/ParserHook.php (modified) (history)
  • /trunk/extensions/Validator/includes/ValidationError.php (modified) (history)
  • /trunk/extensions/Validator/includes/parserHooks/Validator_Describe.php (modified) (history)
  • /trunk/extensions/WebDAV/lib/HTTP/WebDAV/Server.php (modified) (history)
  • /trunk/extensions/WhiteListEdit/WhiteListAuth.php (modified) (history)
  • /trunk/extensions/WhiteListEdit/WhiteListEdit_body.php (modified) (history)
  • /trunk/extensions/WikiAtHome/ApiWikiAtHome.php (modified) (history)
  • /trunk/extensions/WikiAtHome/WikiAtHome.php (modified) (history)
  • /trunk/extensions/WikiAtHome/internalCmdLineEncoder.php (modified) (history)
  • /trunk/extensions/WikiObjectModel/includes/WOM_Processor.php (modified) (history)
  • /trunk/extensions/WikiObjectModel/includes/apis/WOM_SetObjectModel.php (modified) (history)
  • /trunk/extensions/WikiObjectModel/includes/models/WOM_OM_Property.php (modified) (history)
  • /trunk/extensions/WikiObjectModel/includes/models/WOM_OM_Section.php (modified) (history)
  • /trunk/extensions/Wikilog/SpecialWikilog.php (modified) (history)
  • /trunk/extensions/Wikilog/Wikilog.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogComment.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogFeed.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogHooks.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogItemPager.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogMainPage.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogParser.php (modified) (history)
  • /trunk/extensions/Wikilog/WikilogUtils.php (modified) (history)
  • /trunk/extensions/Wikilog/WlFeed.body.php (modified) (history)
  • /trunk/extensions/skins/p2wiki/P2wiki.skin.php (modified) (history)
  • /trunk/extensions/wikihiero/index.php (modified) (history)
  • /trunk/extensions/wikihiero/wh_main.php (modified) (history)
  • /trunk/extensions/wikihiero/wh_table.php (modified) (history)

Comments

#Comment by Nikerabbit (talk | contribs)   17:26, 17 June 2011

This file is not maintained by us: 

trunk/extensions/Translate/spyc/spyc.php
#Comment by 😂 (talk | contribs)   20:28, 19 June 2011
  • whew* Finally done reviewing this and the ones like it. At first I was happy you didn't do it one giant commit, but this was still a really big commit. Please don't do this again anytime soon ;-)

Also like Nikerabbit pointed out, there's a few cases where you applied MW coding conventions to third-party code. Harmless, but will probably be undone next time the library or whatever is updated.

Status & tagging log