r90157 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r90156‎ | r90157 | r90158 >
Date:21:07, 15 June 2011
Author:platonides
Status:ok
Tags:
Comment:
Make sure to die if there are more MediaWikiLangTestCase::tearDowns than setUp()s (such as r90150 & r90155)
Modified paths:
  • /trunk/phase3/tests/phpunit/MediaWikiLangTestCase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/MediaWikiLangTestCase.php
@@ -27,6 +27,7 @@
2828
2929 $wgContLang = self::$oldContLang;
3030 $wgLanguageCode = $wgContLang->getCode();
 31+ self::$oldContLang = self::$oldLang = null;
3132 }
3233
3334 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90150Followup to r90090 -- thou shalt add parent:: calls to both overridden tearDo...brion20:51, 15 June 2011
r90155Follow-up r90150, another parent::setUp missing.platonides21:03, 15 June 2011

Status & tagging log