r90090 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r90089
|
r90090
|
r90091
>
Date:
21:21, 14 June 2011
Author:
platonides
Status:
ok
Tags:
Comment:
Thou shall call parent::tearDown(), MediaWikiLangTestCase child.
Follow up
r87210
. This has been hurting my tests for weeks.
Made TimeAdjustTest extend MediaWikiLangTestCase.
Modified paths:
/trunk/phase3/tests/phpunit/includes/SampleTest.php
(modified) (
history
)
/trunk/phase3/tests/phpunit/includes/TimeAdjustTest.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/tests/phpunit/includes/TimeAdjustTest.php
—
—
@@ -1,6 +1,6 @@
2
2
<?php
3
3
4
-class TimeAdjustTest extends MediaWikiTestCase {
4
+class TimeAdjustTest extends MediaWikiLangTestCase {
5
5
static $offset;
6
6
7
7
public function setUp() {
—
—
@@ -13,6 +13,7 @@
14
14
public function tearDown() {
15
15
global $wgLocalTZoffset;
16
16
$wgLocalTZoffset = self::$offset;
17
+ parent::tearDown();
17
18
}
18
19
19
20
# Test offset usage for a given language::userAdjust
Index: trunk/phase3/tests/phpunit/includes/SampleTest.php
—
—
@@ -15,6 +15,7 @@
16
16
* Anything cleanup you need to do should go here.
17
17
*/
18
18
function tearDown() {
19
+ parent::tearDown();
19
20
}
20
21
21
22
/**
Follow-up revisions
Revision
Commit summary
Author
Date
r90150
Followup to
r90090
-- thou shalt add parent:: calls to both overridden tearDo...
brion
20:51, 15 June 2011
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r87210
Fix the old XmlTest.php test bug in the dateMenu() when the wiki is configure...
platonides
19:32, 1 May 2011
Status & tagging log
02:10, 16 June 2011
😂
(
talk
|
contribs
)
changed the
status
of r90090
[
removed:
new
added:
ok]