r89955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89954‎ | r89955 | r89956 >
Date:09:56, 13 June 2011
Author:wikinaut
Status:ok
Tags:
Comment:
essage=corrected my mistake when comparing if textbox length is empty, or not.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.suggestions.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.suggestions.js
@@ -82,7 +82,7 @@
8383 }
8484
8585 // clear result div if the value in the textbox is empty
86 - if ( context.data.$textbox.val().length != 0 ) {
 86+ if ( context.data.$textbox.val().length == 0 ) {
8787 context.data.$container.hide();
8888 }
8989

Follow-up revisions

RevisionCommit summaryAuthorDate
r89956follow up patch to r89950 r89952 r89953 r89955 : moved div clearing inside ca...wikinaut11:16, 13 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89951fix for bug29368 which may have consequences. Please code reviewers, pls. che...wikinaut09:38, 13 June 2011

Status & tagging log