r89917 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89916‎ | r89917 | r89918 >
Date:05:22, 12 June 2011
Author:neilk
Status:resolved (Comments)
Tags:
Comment:
messages for mw.units.bytes
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
@@ -268,8 +268,15 @@
269269 'mwe-upwiz-feedback-adding' => 'Adding feedback to page...',
270270 'mwe-upwiz-feedback-error1' => 'Error: Unrecognized result from API',
271271 'mwe-upwiz-feedback-error2' => 'Error: Edit failed',
272 - 'mwe-upwiz-feedback-error3' => 'Error: No response from API'
273 -
 272+ 'mwe-upwiz-feedback-error3' => 'Error: No response from API',
 273+
 274+ // similar to mediawiki.special.upload.js
 275+ 'size-terabytes' => '$1 TB',
 276+ 'size-gigabytes' => '$1 GB',
 277+ 'size-megabytes' => '$1 MB',
 278+ 'size-kilobytes' => '$1 K',
 279+ 'size-bytes' => '$1 bytes'
 280+
274281 );
275282
276283 /** Message documentation (Message documentation)
@@ -393,7 +400,7 @@
394401 'mwe-upwiz-feedback-cancel' => 'Button label
395402 {{Identical|Cancel}}',
396403 'mwe-upwiz-feedback-submit' => 'Button label',
397 - 'mwe-upwiz-feedback-adding' => 'Progress notice',
 404+ 'mwe-upwiz-feedback-adding' => 'Progress notice'
398405 );
399406
400407 /** Afrikaans (Afrikaans)

Follow-up revisions

RevisionCommit summaryAuthorDate
r89933Revert r89917 for now. Message keys conlicts with core messages w/exception o...raymond18:58, 12 June 2011
r89998revert r89966, also remove terabytes so we can use system core messages, also...neilk19:08, 13 June 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   17:49, 13 June 2011

kilobytes isn't consistent with the megabytes/gigabytes/terabytes formatting.

#Comment by NeilK (talk | contribs)   19:24, 13 June 2011

fixed in r89933, r89998

Status & tagging log