r89892 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89891‎ | r89892 | r89893 >
Date:20:27, 11 June 2011
Author:rotem
Status:ok (Comments)
Tags:todo 
Comment:
(bug 20044) Misaligned text on file pages (RTL wikis only)
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
——@@ -448,7 +448,7 @@
449449 }
450450
451451 function setHeaders( $out ) {
452 - global $wgOggScriptVersion, $wgCortadoJarFile, $wgServer;
 452+ global $wgOggScriptVersion, $wgCortadoJarFile, $wgServer, $wgContLang;
453453
454454 if ( $out->hasHeadItem( 'OggHandlerScript' ) && $out->hasHeadItem( 'OggHandlerInlineScript' ) &&
455455 $out->hasHeadItem( 'OggHandlerInlineCSS' ) ) {
——@@ -471,6 +471,7 @@
472472 }
473473 $encCortadoUrl = Xml::encodeJsVar( $cortadoUrl );
474474 $encExtPathUrl = Xml::encodeJsVar( $scriptPath );
 475+ $alignStart = $wgContLang->alignStart();
475476
476477 $out->addHeadItem( 'OggHandlerScript' , Html::linkedScript( "{$scriptPath}/OggPlayer.js?$wgOggScriptVersion" ) );
477478
——@@ -487,7 +488,7 @@
488489 .ogg-player-options {
489490 border: solid 1px #ccc;
490491 padding: 2pt;
491 - text-align: left;
 492+ text-align: $alignStart;
492493 font-size: 10pt;
493494 }
494495

Follow-up revisions

RevisionCommit summaryAuthorDate
r92945Fix r89892 so it uses wgLang when appropriate.robin14:50, 23 July 2011

Comments

#Comment by Siebrand (talk | contribs)   23:07, 12 July 2011

Shouldn't this be done with flip/noflip?

#Comment by Catrope (talk | contribs)   01:45, 13 July 2011

Yes, but the CSS is inside the PHP for some reason. If it's in a ResourceLoader module, CSSJanus will take care of the flipping automatically.

#Comment by Siebrand (talk | contribs)   09:38, 13 July 2011

Adding "todo" label so someone might some day notice this...

#Comment by Reedy (talk | contribs)   21:50, 24 August 2011

bug 30556 logged about RL'ifying OggHandler

Status & tagging log