r89876 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89875‎ | r89876 | r89877 >
Date:10:37, 11 June 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
mediawiki.util.test.js: IE7 doesn't expose the CSSStyleSheet publicly (like it doesn't for many). Checking object type instead.
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki.util/mediawiki.util.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki.util/mediawiki.util.js
@@ -50,7 +50,7 @@
5151 expect(3);
5252
5353 var a = mw.util.addCSS( '#bodyContent { visibility: hidden; }' );
54 - ok( a instanceof CSSStyleSheet, 'Object is an instance of CSSStyleSheet' );
 54+ equal( typeof a, 'object', 'addCSS returned an object' );
5555 strictEqual( a.disabled, false, 'property "disabled" is available and set to false' );
5656
5757 var $b = $('#bodyContent');

Comments

#Comment by Aaron Schulz (talk | contribs)   20:45, 21 June 2011

Could use a code comment.

Status & tagging log