r89817 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89816‎ | r89817 | r89818 >
Date:07:48, 10 June 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Fix for logic error in r89529 causing a notice.
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -94,7 +94,7 @@
9595 if ( !$vars ) {
9696 return; // no LocalSettings found
9797 }
98 - if ( !isset( $vars['wgHooks'] ) && !isset( $vars['wgHooks']['LoadExtensionSchemaUpdates'] ) ) {
 98+ if ( !isset( $vars['wgHooks'] ) || !isset( $vars['wgHooks']['LoadExtensionSchemaUpdates'] ) ) {
9999 return;
100100 }
101101 global $wgHooks, $wgAutoloadClasses;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89529Follow-up r89254 and r89481: re-did loading extension updates properly, now u...maxsem19:52, 5 June 2011

Comments

#Comment by Siebrand (talk | contribs)   22:18, 11 July 2011

Tagging 1.18 because r89529 is tagged 1.18.

Status & tagging log