r89653 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89652‎ | r89653 | r89654 >
Date:15:52, 7 June 2011
Author:maxsem
Status:ok
Tags:
Comment:
Fix r85021: extension tables weren't created in some cases
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseInstaller.php
@@ -186,11 +186,6 @@
187187 $updater = DatabaseUpdater::newForDB( $this->db );
188188 $extensionUpdates = $updater->getNewExtensions();
189189
190 - // No extensions need tables (or haven't updated to new installer support)
191 - if( !count( $extensionUpdates ) ) {
192 - return $status;
193 - }
194 -
195190 $ourExtensions = array_map( 'strtolower', $this->getVar( '_Extensions' ) );
196191
197192 foreach( $ourExtensions as $ext ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r89660Get rid of addNewExtension()/getNewExtensions() method of adding new extensio...demon17:33, 7 June 2011
r896771.17: MFT r88492, r88870, r88871, r89003, r89108, r89114, r89115, r89129, r89...catrope19:14, 7 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r85021(bug 28237) Installer doesn't create extension tablesmaxsem17:32, 30 March 2011

Status & tagging log