r89507 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89506‎ | r89507 | r89508 >
Date:16:34, 5 June 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 28897) rvparse doesn’t seem to work with rvsection
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -95,6 +95,7 @@
9696 * (bug 29070) Add token to action=watch
9797 * (bug 29221) Expose oldrevid in watchlist output
9898 * (bug 29267) always give the servername for meta=siteinfo&siprop=dbrepllag
 99+* (bug 28897) rvparse doesn’t seem to work with rvsection
99100
100101 === Languages updated in 1.19 ===
101102
Index: trunk/phase3/includes/api/ApiParse.php
@@ -297,11 +297,11 @@
298298 }
299299
300300 /**
301 - * @param $articleObj Article
302 - * @param $titleObj Title
303 - * @param $popts ParserOptions
304 - * @param $pageId Int
305 - * @param $getWikitext Bool
 301+ * @param $articleObj Article
 302+ * @param $titleObj Title
 303+ * @param $popts ParserOptions
 304+ * @param $pageId Int
 305+ * @param $getWikitext Bool
306306 * @return ParserOutput
307307 */
308308 private function getParsedSectionOrText( $articleObj, $titleObj, $popts, $pageId = null, $getWikitext = false ) {
Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -482,10 +482,7 @@
483483 $text = $wgParser->preprocess( $text, $title, new ParserOptions() );
484484 }
485485 if ( $this->parseContent ) {
486 - $articleObj = new Article( $title );
487 -
488 - $p_result = $articleObj->getParserOutput();
489 - $text = $p_result->getText();
 486+ $text = $wgParser->parse( $text, $title, new ParserOptions() )->getText();
490487 }
491488 ApiResult::setContent( $vals, $text );
492489 } elseif ( $this->fld_content ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r90695More RELEASE-NOTES-1.19 tweaksaaron08:29, 24 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75266Added rvparse to parse revisions. For performance reasons if this option is u...btongminh16:41, 23 October 2010

Comments

#Comment by Nikerabbit (talk | contribs)   20:38, 5 June 2011

Is that understandable release notes entry?

Status & tagging log