r89499 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89498‎ | r89499 | r89500 >
Date:13:47, 5 June 2011
Author:zhenya
Status:deferred (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/extensions/SocialProfile/UserStatus/UserStatus.js (added) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserStatus/UserStatus.js
——@@ -0,0 +1,11 @@
 2+var STATUS = "[this is status]";
 3+var editModeOff = false;
 4+
 5+
 6+function toEditMode () {
 7+ document.getElementById("status").innerHTML = "<input type='text' value='STATUS'><a href='javascript:cancel()'>Cancel</a>";
 8+}
 9+
 10+function setStatus () {
 11+ document.getElementById("status").innerHTML = STATUS + ' _ ';
 12+}
Property changes on: trunk/extensions/SocialProfile/UserStatus/UserStatus.js
___________________________________________________________________
Added: svn:eol-style
113 + native

Comments

#Comment by Jack Phoenix (talk | contribs)   17:35, 5 June 2011

Where's the commit message? ;-)

There are a few coding style issues, but since this is a work in progress, I suppose it's not such a big deal yet. IIRC there are very few cases in JavaScript where you really need/must use "double quotes". 

+function toEditMode () {
...
+function setStatus () {

No need for the space after function name, but before the opening parenthesis mark.

Status & tagging log