r89497 MediaWiki - Code Review archive

+CREATE TABLE IF NOT EXISTS `user_status` (

We don't normally include the IF NOT EXISTS clause in our table definitions, but I personally don't mind it. However, you should drop the `backticks` and prefix the table name with /*_*/ for database prefix/SQLite compatibility.

+  `id` int(11) NOT NULL AUTO_INCREMENT,
...
+  PRIMARY KEY (`id`)

The PRIMARY KEY definition should be in the initial column definition for SQLite compatibility, like this: `id` int(11) NOT NULL PRIMARY KEY AUTO_INCREMENT

Also, we normally prefix column fields with either the table name (if the table name is very short, such as page) or an abbreviation of the table name, for tables which have longer names. Admittedly, this is not true for all SocialProfile fields, because of historical reasons. Still, we shouldn't repeat mistakes made by others in the past. I'd suggest us as the prefix for these columns. For example:

• id → us_id
• user_id → us_user_id or maybe us_user (see for example revision.rev_user)
• user_date → us_user_date (is this the field that holds the timestamp for the status message? If so, it should probably be called us_timestamp or something like that for consistency; see revision.rev_timestamp)
• user_name → us_user_text (in core MediaWiki most fields that contain the user name are called something_text, for example revision.rev_user_text)
• user_status → us_status or maybe even us_status_text (also, is text the correct type here? IIRC SocialProfile uses text for a few columns, but core MediaWiki doesn't...maybe it's not such a big deal.)