r89414 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89413‎ | r89414 | r89415 >
Date:14:36, 3 June 2011
Author:happy-melon
Status:reverted (Comments)
Tags:
Comment:
Follow-up r89406 CR: another use of RequestContext::__get()
Modified paths:
  • /trunk/phase3/includes/StubObject.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/StubObject.php
——@@ -148,6 +148,6 @@
149149 }
150150
151151 function _newObject() {
152 - return RequestContext::getMain()->lang;
 152+ return RequestContext::getMain()->getLang();
153153 }
154154 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r89430Provisional revert of r89406, r89414: reference-related warnings need cleanup...brion18:48, 3 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89406Start unpicking r85288 (magic __get() accessor for RequestContext). Instead,...happy-melon10:54, 3 June 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:49, 3 June 2011

Provisionally reverted in r89430 along with problematic parent commit r89406.

Status & tagging log