r89367 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89366‎ | r89367 | r89368 >
Date:21:15, 2 June 2011
Author:tparscal
Status:ok
Tags:
Comment:
Aye kant zpell
Modified paths:
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/ArticleFeedback.hooks.php
@@ -63,8 +63,8 @@
6464 'articlefeedback-error',
6565 'articlefeedback-form-switch-label',
6666 'articlefeedback-form-panel-title',
67 - 'articlefeedback-form-panel-explaination',
68 - 'articlefeedback-form-panel-explaination-link',
 67+ 'articlefeedback-form-panel-explanation',
 68+ 'articlefeedback-form-panel-explanation-link',
6969 'articlefeedback-form-panel-clear',
7070 'articlefeedback-form-panel-expertise',
7171 'articlefeedback-form-panel-expertise-studies',
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -60,7 +60,7 @@
6161 <div class="articleFeedback-switch articleFeedback-switch-form articleFeedback-visibleWith-report" rel="form"><html:msg key="form-switch-label" /></div>\
6262 <div class="articleFeedback-title articleFeedback-visibleWith-form"><html:msg key="form-panel-title" /></div>\
6363 <div class="articleFeedback-title articleFeedback-visibleWith-report"><html:msg key="report-panel-title" /></div>\
64 - <div class="articleFeedback-explaination articleFeedback-visibleWith-form"><a class="articleFeedback-explaination-link"><html:msg key="form-panel-explaination" /></a></div>\
 64+ <div class="articleFeedback-explanation articleFeedback-visibleWith-form"><a class="articleFeedback-explanation-link"><html:msg key="form-panel-explanation" /></a></div>\
6565 <div class="articleFeedback-description articleFeedback-visibleWith-report"><html:msg key="report-panel-description" /></div>\
6666 <div style="clear:both;"></div>\
6767 <div class="articleFeedback-ratings"></div>\
@@ -499,9 +499,9 @@
500500 }
501501 } )
502502 .end()
503 - .find( '.articleFeedback-explaination-link' )
 503+ .find( '.articleFeedback-explanation-link' )
504504 .attr( 'href', mw.config.get( 'wgArticlePath' ).replace(
505 - '$1', mw.msg( 'articlefeedback-form-panel-explaination-link' )
 505+ '$1', mw.msg( 'articlefeedback-form-panel-explanation-link' )
506506 ) )
507507 .end()
508508 .find( '.articleFeedback-pitches' )
Index: trunk/extensions/ArticleFeedback/modules/jquery.articleFeedback/jquery.articleFeedback.css
@@ -164,7 +164,7 @@
165165 background-image: url(images/report-hover.png);
166166 }
167167
168 -.articleFeedback-explaination, .articleFeedback-description {
 168+.articleFeedback-explanation, .articleFeedback-description {
169169 float: left;
170170 font-weight: bold;
171171 margin-bottom: 0.75em;
Index: trunk/extensions/ArticleFeedback/ArticleFeedback.i18n.php
@@ -30,8 +30,8 @@
3131 'articlefeedback-error' => 'An error has occured. Please try again later.',
3232 'articlefeedback-form-switch-label' => 'Rate this page',
3333 'articlefeedback-form-panel-title' => 'Rate this page',
34 - 'articlefeedback-form-panel-explaination' => 'What\'s this?',
35 - 'articlefeedback-form-panel-explaination-link' => 'Project:ArticleFeedback',
 34+ 'articlefeedback-form-panel-explanation' => 'What\'s this?',
 35+ 'articlefeedback-form-panel-explanation-link' => 'Project:ArticleFeedback',
3636 'articlefeedback-form-panel-clear' => 'Remove this rating',
3737 'articlefeedback-form-panel-expertise' => 'I am highly knowledgeable about this topic (optional)',
3838 'articlefeedback-form-panel-expertise-studies' => 'I have a relevant college/university degree',

Follow-up revisions

RevisionCommit summaryAuthorDate
r894441.17wmf1: MFT r89360, r89365, r89367catrope21:09, 3 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89365Replaced "instructions" message with"explaination" message, which links by de...tparscal21:05, 2 June 2011

Status & tagging log