r89304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89303‎ | r89304 | r89305 >
Date:23:59, 1 June 2011
Author:nimishg
Status:ok
Tags:
Comment:
Does proper check for if the active campaigns exist
Modified paths:
  • /trunk/extensions/ClickTracking/modules/ext.UserBuckets.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ClickTracking/modules/ext.UserBuckets.js
@@ -77,7 +77,7 @@
7878 };
7979
8080 // No need to do any of this if there are no active campaigns
81 -if ( mw.activeCampaigns && mw.activeCampaigns.length ) {
 81+if ( mw.activeCampaigns && !$.isEmptyObject(mw.activeCampaigns) ) {
8282 $( $.setupActiveBuckets );
8383 }
8484

Status & tagging log