r89305 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89304‎ | r89305 | r89306 >
Date:00:01, 2 June 2011
Author:nimishg
Status:ok (Comments)
Tags:
Comment:
Changed default path of cookie
Modified paths:
  • /trunk/extensions/ClickTracking/ClickTracking.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ClickTracking/ClickTracking.hooks.php
——@@ -160,7 +160,7 @@
161161
162162 //NOTE: $wgRequest->response setCookie sets it with a prefix and httponly by default
163163 setcookie( 'userbuckets' , $packedBuckets ,
164 - time() + 60 * 60 * 24 * 365 ); //expire in 1 year
 164+ time() + 60 * 60 * 24 * 90 , '/' ); //expire in 90 days
165165 }
166166
167167 /**

Comments

#Comment by Nikerabbit (talk | contribs)   08:29, 2 June 2011

Does not match commit summary.

#Comment by Hashar (talk | contribs)   12:23, 14 August 2011

Marking fixme. Are you sure you want the cookie to expire after 90 days? If so we can mark this revision ok.

#Comment by P858snake (talk | contribs)   12:26, 14 August 2011

Shouldn't we keep this to 30 days like the login cookie?

#Comment by MaxSem (talk | contribs)   12:33, 14 August 2011

You mean, 180 days? :)

#Comment by Nimish Gautam (talk | contribs)   17:27, 17 August 2011

Yeah, this was meant to be 90 days, the commit message is wrong and should read something like "changed the default expiry for cookie as per request"

Status & tagging log