r89262 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89261‎ | r89262 | r89263 >
Date:14:18, 1 June 2011
Author:freakolowsky
Status:ok (Comments)
Tags:
Comment:
* used Html static functions instead og Xml. (r89260#c17418)
Modified paths:
  • /trunk/phase3/includes/Html.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Html.php
@@ -693,25 +693,25 @@
694694 $icon = $wgStylePath.'/common/images/'.$icon;
695695 }
696696
697 - $s = Xml::openElement( 'div', array( 'class' => "mw-infobox $class") );
 697+ $s = Html::openElement( 'div', array( 'class' => "mw-infobox $class") );
698698
699 - $s .= Xml::openElement( 'div', array( 'class' => 'mw-infobox-left' ) ).
 699+ $s .= Html::openElement( 'div', array( 'class' => 'mw-infobox-left' ) ).
700700 Html::element( 'img',
701701 array(
702702 'src' => $icon,
703703 'alt' => $alt,
704704 )
705705 ).
706 - Xml::closeElement( 'div' );
 706+ Html::closeElement( 'div' );
707707
708 - $s .= Xml::openElement( 'div', array( 'class' => 'mw-infobox-right' ) ).
 708+ $s .= Html::openElement( 'div', array( 'class' => 'mw-infobox-right' ) ).
709709 $text.
710 - Xml::closeElement( 'div' );
711 - $s .= Xml::element( 'div', array( 'style' => 'clear: left;' ), ' ' );
 710+ Html::closeElement( 'div' );
 711+ $s .= Html::element( 'div', array( 'style' => 'clear: left;' ), ' ' );
712712
713 - $s .= Xml::closeElement( 'div' );
 713+ $s .= Html::closeElement( 'div' );
714714
715 - $s .= Xml::element( 'div', array( 'style' => 'clear: left;' ), ' ' );
 715+ $s .= Html::element( 'div', array( 'style' => 'clear: left;' ), ' ' );
716716
717717 return $s;
718718 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89260* moved infobox to Html (r88109#c16937)freakolowsky13:57, 1 June 2011

Comments

#Comment by Freakolowsky (talk | contribs)   15:25, 1 June 2011

could you also change status on previous commits?

r89260 r88109

Status & tagging log