r89258 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89257‎ | r89258 | r89259 >
Date:13:51, 1 June 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 29224) Also use a packed modules string for the startup modules (usually there's only one, but there's a hook to add more)
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php
——@@ -185,7 +185,7 @@
186186 }
187187 // Build load query for StartupModules
188188 $query = array(
189 - 'modules' => implode( '|', $modules ),
 189+ 'modules' => ResourceLoader::makePackedModulesString( $modules ),
190190 'only' => 'scripts',
191191 'lang' => $context->getLanguage(),
192192 'skin' => $context->getSkin(),

Comments

#Comment by Catrope (talk | contribs)   13:56, 1 June 2011

Patch by Michael Dale.

#Comment by Brion VIBBER (talk | contribs)   20:44, 3 June 2011

Confirmed working ok with TimedMediaHandler.

Status & tagging log