r89249 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89248‎ | r89249 | r89250 >
Date:02:05, 1 June 2011
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Fix for r89248: don't run the regex if findIE6Extension returns false. Only affects performance, the logic is the same.
Modified paths:
  • /trunk/phase3/includes/WebRequest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/WebRequest.php
——@@ -884,7 +884,7 @@
885885 }
886886
887887 $extension = self::findIE6Extension( $_SERVER['QUERY_STRING'] );
888 - if ( $extension === '' ) {
 888+ if ( strval( $extension ) === '' ) {
889889 return false;
890890 }
891891

Follow-up revisions

RevisionCommit summaryAuthorDate
r89291Document r89248,r89249 isQueryStringBad()platonides21:22, 1 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89248* Only blacklist query string extensions which match /^[a-zA-Z0-9_-]+$/. This...tstarling02:01, 1 June 2011

Comments

#Comment by Tim Starling (talk | contribs)   06:47, 5 July 2011

Untagging 1.17wmf1 since it has been superseded by r91440.

Status & tagging log