r89208 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r89207‎ | r89208 | r89209 >
Date:06:17, 31 May 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
revert r84022 parser tests (code reverted by r89088)

The code cause bug 29197 (PHP 5.3.x crash) and the parser tests are
blocking cruise control.
Modified paths:
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -976,33 +976,6 @@
977977 !! end
978978
979979 !! test
980 -External links: links containing empty bracket pair []
981 -!! input
982 -[http://example.com?parameter[]=foo link]
983 -!! result
984 -<p><a rel="nofollow" class="external text" href="http://example.com?parameter%5B%5D=foo">link</a>
985 -</p>
986 -!! end
987 -
988 -!! test
989 -External links: links ending in empty bracket pair []
990 -!! input
991 -[http://example.com?parameter[]=foo&option[]]
992 -!! result
993 -<p><a rel="nofollow" class="external autonumber" href="http://example.com?parameter%5B%5D=foo&amp;option%5B%5D">[1]</a>
994 -</p>
995 -!! end
996 -
997 -!! test
998 -External links: bare links ending in empty bracket pair []
999 -!! input
1000 -http://example.com?parameter[]=foo&option[]
1001 -!! result
1002 -<p><a rel="nofollow" class="external free" href="http://example.com?parameter%5B%5D=foo&amp;option%5B%5D">http://example.com?parameter%5B%5D=foo&amp;option%5B%5D</a>
1003 -</p>
1004 -!! end
1005 -
1006 -!! test
1007980 BUG 787: Links with one slash after the url protocol are invalid
1008981 !! input
1009982 http:/example.com

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r84022Accept empty square bracket pairs in external links: http://www.example.com?f...happy-melon15:09, 15 March 2011
r89088Rv r84022 for now: crashes PHP on large url strings (bug29197), which is a na...happy-melon09:32, 29 May 2011

Comments

#Comment by Hashar (talk | contribs)   07:38, 31 May 2011

I am not sure I made the correct revert this morning :/

#Comment by Platonides (talk | contribs)   15:36, 31 May 2011

I think you should have just marked them as broken.

Status & tagging log