r89195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r89194‎ | r89195 | r89196 >
Date:00:19, 31 May 2011
Author:wikinaut
Status:ok (Comments)
Tags:
Comment:
when dragging to a new location, set all possible dropping zones to yellow background, and set the droppong zone under cursor to springgreen bg - to attract users' attention.
Modified paths:
  • /trunk/extensions/LiquidThreads/lqt.css (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/lqt.css
——@@ -464,18 +464,21 @@
465465 margin-top: 1em;
466466 margin-bottom: 1em;
467467 padding: 0.5em 1em;
468 - border: 1px solid #999999;
 468+ border: 1px solid #3333ff !important;
 469+ background: yellow;
469470 text-align: center;
470471 color: #999999;
471472 }
472473
473474 .lqt-drop-zone.lqt-drop-zone-active {
474475 border: 1px solid #3333ff !important;
 476+ background: yellow;
475477 }
476478
477479 .lqt-drop-zone.lqt-drop-zone-hover {
478 - border: 2px solid #3333ff !important;
 480+ border: 1px solid #3333ff !important;
479481 color: #3333ff !important;
 482+ background: springgreen;
480483 font-weight: bold !important;
481484 }
482485

Follow-up revisions

RevisionCommit summaryAuthorDate
r89209chg colour name from X11/CSS3 springgreen to hex notation as suggestedwikinaut06:55, 31 May 2011

Comments

#Comment by Nikerabbit (talk | contribs)   06:22, 31 May 2011

Color springgreen seems to be CSS3 only?

#Comment by Wikinaut (talk | contribs)   06:57, 31 May 2011

corr in r89209 . You are correct see http://en.wikipedia.org/wiki/Web_colors . Should never happen again, thanks.

#Comment by P858snake (talk | contribs)   07:22, 31 May 2011

Isn't most of the LQT redesign/update happening in a separate branch so wouldn't it be better to work on it there?

#Comment by Nikerabbit (talk | contribs)   07:24, 31 May 2011

No. It could possible be merged there if the code hasn't been changed.

#Comment by Werdna (talk | contribs)   07:27, 31 May 2011

Yes, but this isn't really rework.

#Comment by Werdna (talk | contribs)   07:28, 31 May 2011

I'm not sure I like the yellow, it's a bit too obnoxious for my taste.

#Comment by 😂 (talk | contribs)   04:59, 17 June 2011

+1

#Comment by Wikinaut (talk | contribs)   07:38, 31 May 2011

I already tried "lighter" colours such as "lightgreen". The problem is, that then the drop zones are not very distinct from the text (not much different from the status quo ante), colours are *always* a question of taste, and perhaps we can find a better one. But as Nikerrabbit point out, my work is *not* the rework. I "only" fix the several bugs in the current version, because this is the one used everywhere.

Status & tagging log