r88971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88970‎ | r88971 | r88972 >
Date:15:22, 27 May 2011
Author:kbrown
Status:reverted (Comments)
Tags:
Comment:
Modified paths:
  • /trunk/extensions/Cite/Cite_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Cite/Cite_body.php
@@ -982,10 +982,11 @@
983983 * Gets run when Parser::clearState() gets run, since we don't
984984 * want the counts to transcend pages and other instances
985985 */
986 - function clearState() {
 986+ function clearState( $parser ) {
 987+ global $wgParser;
987988 # Don't clear state when we're in the middle of parsing
988 - # a <ref> tag
989 - if ( $this->mInCite || $this->mInReferences ) {
 989+ # a <ref> tag or parsing messages
 990+ if ( $this->mInCite || $this->mInReferences || $parser !== $wgParser ) {
990991 return true;
991992 }
992993

Follow-up revisions

RevisionCommit summaryAuthorDate
r89220Remove Cite singleton. Store it inside each associated parser at $parser->ext...platonides17:49, 31 May 2011
r89221Follow up r89220. Misleading comment left from r88971platonides17:51, 31 May 2011

Comments

#Comment by Platonides (talk | contribs)   16:47, 31 May 2011

Breaks cite parsertests.

Status & tagging log