r88686 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88685‎ | r88686 | r88687 >
Date:21:02, 23 May 2011
Author:nelson
Status:ok
Tags:
Comment:
Special:MovePage was broken. Isn't anymore.
Modified paths:
  • /trunk/extensions/SwiftMedia/SwiftMedia.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SwiftMedia/SwiftMedia.body.php
@@ -2464,7 +2464,7 @@
24652465 * @return Either array of files and existence flags, or false
24662466 */
24672467 function fileExistsBatch( $files, $flags = 0 ) {
2468 - if (flags != self::FILES_ONLY) {
 2468+ if ($flags != self::FILES_ONLY) {
24692469 // we ONLY support when $flags & self::FILES_ONLY is set!
24702470 throw new MWException( 'Swift Media Store doesn\'t have directories');
24712471 }
@@ -2628,17 +2628,15 @@
26292629 foreach ( $files as $file ) {
26302630 if ( is_array( $file ) ) {
26312631 // This is a pair, extract it
2632 - list( $zone, $rel ) = $file;
2633 - $cont = $this->getZonePath( $zone );
 2632+ list( $cont, $rel ) = $file;
26342633 } else {
26352634 if ( self::isVirtualUrl( $file ) ) {
26362635 // This is a virtual url, resolve it
26372636 $path = $this->resolveVirtualUrl( $file );
2638 - list( $zone, $rel) = $path;
2639 - $cont = $this->getZonePath( $zone );
 2637+ list( $cont, $rel) = $path;
26402638 } else {
26412639 // FIXME: This is a full file name
2642 - throw new MWException( __METHOD__.': $file' );
 2640+ throw new MWException( __METHOD__.': $file needs an unlink()' );
26432641 }
26442642 }
26452643

Status & tagging log