r88685 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88684‎ | r88685 | r88686 >
Date:21:01, 23 May 2011
Author:foxtrott
Status:deferred
Tags:
Comment:
followup r88564: no need to call clearState, it's called by parse anyway
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormPrinter.php
@@ -63,7 +63,6 @@
6464 */
6565 public function registerInputType( $inputTypeClass ) {
6666 global $smwgContLang;
67 - global $sfgInitJSFunctions, $sfgValidationJSFunctions;
6867
6968 $inputTypeName = call_user_func( array( $inputTypeClass, 'getName' ) );
7069 $this->mInputTypeClasses[$inputTypeName] = $inputTypeClass;
@@ -361,8 +360,7 @@
362361 $oldParser = $wgParser;
363362
364363 $wgParser = unserialize( serialize( $oldParser ) ); // deep clone of parser
365 - $wgParser->clearState();
366 -
 364+
367365 // Get the form definition from the cache, if we're using caching and it's
368366 // there.
369367 // $got_form_def_from_cache = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88564bugfix: use clone of wgParser instead of new Parser for form parsingfoxtrott08:41, 22 May 2011