r88487 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88486‎ | r88487 | r88488 >
Date:21:17, 20 May 2011
Author:platonides
Status:deferred (Comments)
Tags:
Comment:
Implement in two lines the check for @ that r88187 added to checkSyntax.php
Modified paths:
  • /trunk/tools/code-utils/check-vars.php (modified) (history)

Diff [purge]

Index: trunk/tools/code-utils/check-vars.php
——@@ -429,6 +429,8 @@
430430 // This way we don't complay about missing return in internal wfProfile sections.
431431 $this->mAfterProfileOut = 3;
432432 }
 433+ } elseif ( $token == '@' ) {
 434+ $this->warning( "Use of @ operator in function {$this->mFunction}" );
433435 } elseif ( is_array ( $token ) ) {
434436 if ( $token[0] == T_GLOBAL ) {
435437 $this->mStatus = self::IN_GLOBAL;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88187Add check for evil, EVIL @demon14:32, 15 May 2011

Comments

#Comment by Hashar (talk | contribs)   21:19, 20 May 2011

This rev came at a perfect time:

[23:17] ^demon: Really, we should merge check-vars and checkSyntax into one script in code-utils.

[23:17] ^demon: Then I could finally make a nice pre-commit hook again :)

[23:17] codurr: platonides * <r88487> /trunk/tools/code-utils/check-vars.php: Implement in two lines the check for @ that r88187 added to checkSyntax.php

Status & tagging log