r88294 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88293‎ | r88294 | r88295 >
Date:11:41, 17 May 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
* (bug 29022) Link to disable email notifications should be in the email notification

Adds a line linking to Special:Preferences to enotif_body message that formats watchlist-based email notifications.
This allows the receiving user to immediately go adjust their settings if they decide they don't want them.

Only changed the English message; needs to be duplicated in localizations.

(Long-term, this message should be broken up so the header lines can be handled independently.)
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2769,6 +2769,9 @@
27702770 Your friendly {{SITENAME}} notification system
27712771
27722772 --
 2773+To change your email notification settings, visit
 2774+{{fullurl:{{#special:Preferences}}}}
 2775+
27732776 To change your watchlist settings, visit
27742777 {{fullurl:{{#special:Watchlist}}/edit}}
27752778

Follow-up revisions

RevisionCommit summaryAuthorDate
r882951.17wmf1: MFT r88294catrope11:55, 17 May 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   11:47, 17 May 2011

Marking for 1.17-wmf merge so we can push it more quickly than LU will grab it

#Comment by Brion VIBBER (talk | contribs)   11:48, 17 May 2011

as noted LU actually won't pick this up since it changed in English -- def needs the deploy

Status & tagging log