r88291 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88290‎ | r88291 | r88292 >
Date:10:08, 17 May 2011
Author:kaldari
Status:ok
Tags:
Comment:
less confusing config var name, condensing comment to 1 line
Modified paths:
  • /trunk/extensions/WikiLove/wikiLove.js (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiLove/wikiLove.js
@@ -12,8 +12,7 @@
1313 descr: 'Original barnstar', // description in the menu
1414 text: '{{subst:The Original Barnstar|$1 ~~~~}}', // message text, $1 is replaced by the user message
1515 template: 'The Original Barnstar', // template that is used, for statistics
16 - mail: 'Hello $2!\n\nI just awarded you a barnstar.' // message to use in email notification
17 - // $2 is replaced by the recipient's username
 16+ mail: 'Hello $2!\n\nI just awarded you a barnstar.' // message to use in email notification; $2 is replaced by the recipient's username
1817 },
1918 'special': {
2019 title: null, // no predefined title, allows the user to enter a title
@@ -23,7 +22,7 @@
2423 mail: 'Hello $2!\n\nI just awarded you the special barnstar.'
2524 }
2625 },
27 - email: true, // add email notices as an option for each award of this type
 26+ showNotify: true, // add email notices as an option for each award of this type
2827 icon: mw.config.get( 'wgServer' ) + mw.config.get( 'wgScriptPath' ) + '/extensions/WikiLove/images/icons/wikilove-icon-barnstar.png'
2928 },
3029 'cat': {
@@ -286,7 +285,7 @@
287286 $( '#wlGallery' ).hide();
288287 }
289288
290 - if( $.wikiLove.types[$.wikiLove.currentTypeId].email ) {
 289+ if( $.wikiLove.types[$.wikiLove.currentTypeId].showNotify ) {
291290 $( '#wlNotify' ).show();
292291 } else {
293292 $( '#wlNotify' ).hide();

Status & tagging log