r88290 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88289‎ | r88290 | r88291 >
Date:08:46, 17 May 2011
Author:siebrand
Status:ok
Tags:
Comment:
Make @deprecated documentation more consistent (see: http://svn.wikimedia.org/doc/deprecated.html).
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2355,8 +2355,8 @@
23562356 /**
23572357 * Get the current skin, loading it if required
23582358 * @return Skin The current skin
2359 - * @todo: FIXME : need to check the old failback system [AV]
2360 - * @deprecated Use ->getSkin() in the most relevant outputting context you have
 2359+ * @todo FIXME : need to check the old failback system [AV]
 2360+ * @deprecated since 1.18 Use ->getSkin() in the most relevant outputting context you have
23612361 */
23622362 function getSkin() {
23632363 return RequestContext::getMain()->getSkin();
Index: trunk/phase3/includes/GlobalFunctions.php
@@ -610,7 +610,7 @@
611611 /**
612612 * Get a message from the language file, for the UI elements
613613 *
614 - * @deprecated in 1.18; use wfMessage()
 614+ * @deprecated since 1.18; use wfMessage()
615615 */
616616 function wfMsgNoDB( $key ) {
617617 wfDeprecated( __FUNCTION__ );
@@ -622,7 +622,7 @@
623623 /**
624624 * Get a message from the language file, for the content
625625 *
626 - * @deprecated in 1.18; use wfMessage()
 626+ * @deprecated since 1.18; use wfMessage()
627627 */
628628 function wfMsgNoDBForContent( $key ) {
629629 wfDeprecated( __FUNCTION__ );
@@ -660,7 +660,7 @@
661661 /**
662662 * This function provides the message source for messages to be edited which are *not* stored in the database.
663663 *
664 - * @deprecated in 1.18; use wfMessage()
 664+ * @deprecated since 1.18; use wfMessage()
665665 * @param $key String
666666 */
667667 function wfMsgWeirdKey( $key ) {
@@ -3174,7 +3174,7 @@
31753175 /**
31763176 * Load an extension messages file
31773177 *
3178 - * @deprecated in 1.16, warnings in 1.18, remove in 1.20
 3178+ * @deprecated since 1.16, warnings in 1.18, remove in 1.20
31793179 * @codeCoverageIgnore
31803180 */
31813181 function wfLoadExtensionMessages() {
@@ -3268,7 +3268,7 @@
32693269
32703270 /**
32713271 * Used to be used for outputting text in the installer/updater
3272 - * @deprecated Warnings in 1.19, removal in 1.20
 3272+ * @deprecated since 1.18, warnings in 1.19, remove in 1.20
32733273 */
32743274 function wfOut( $s ) {
32753275 wfDeprecated( __METHOD__ );
Index: trunk/phase3/includes/api/ApiParse.php
@@ -369,7 +369,8 @@
370370 }
371371
372372 /**
373 - * @deprecated No modern skin generates langlinks this way, please use langlinks data to generate your own html
 373+ * @deprecated since 1.18 No modern skin generates language links this way, please use language links
 374+ * data to generate your own HTML.
374375 */
375376 private function languagesHtml( $languages ) {
376377 global $wgContLang, $wgHideInterlanguageLinks;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -2985,7 +2985,7 @@
29862986
29872987 /**
29882988 * Backward compatibility setting, will set $wgArticleCountMethod if it is null.
2989 - * @deprecated in 1.19; use $wgArticleCountMethod instead
 2989+ * @deprecated since 1.19; use $wgArticleCountMethod instead
29902990 */
29912991 $wgUseCommaCount = false;
29922992
@@ -3138,7 +3138,7 @@
31393139
31403140 /**
31413141 * Whether or not to allow and use real name fields.
3142 - * @deprecated in 1.16, use $wgHiddenPrefs[] = 'realname' below to disable real
 3142+ * @deprecated since 1.16, use $wgHiddenPrefs[] = 'realname' below to disable real
31433143 * names
31443144 */
31453145 $wgAllowRealName = true;
Index: trunk/phase3/includes/SpecialPage.php
@@ -109,7 +109,7 @@
110110 * an associative record to $wgSpecialPages. This avoids autoloading SpecialPage.
111111 *
112112 * @param $page SpecialPage
113 - * @deprecated in 1.7, warnings in 1.17, might be removed in 1.20
 113+ * @deprecated since 1.7, warnings in 1.17, might be removed in 1.20
114114 */
115115 static function addPage( &$page ) {
116116 wfDeprecated( __METHOD__ );

Status & tagging log