r88232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88231‎ | r88232 | r88233 >
Date:12:50, 16 May 2011
Author:midom
Status:ok (Comments)
Tags:
Comment:
unbreak ProfilerSimpleTrace, some Profile refactoring made it not worky :( Also, add it to AutoLoader
Modified paths:
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/profiler/ProfilerSimpleTrace.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/profiler/ProfilerSimpleTrace.php
@@ -60,7 +60,7 @@
6161 return $diff / 1024;
6262 }
6363
64 - function getOutput() {
 64+ function logData() {
6565 print "<!-- \n {$this->trace} \n -->";
6666 }
6767 }
Index: trunk/phase3/includes/AutoLoader.php
@@ -601,6 +601,7 @@
602602 'Profiler' => 'includes/profiler/Profiler.php',
603603 'ProfilerSimple' => 'includes/profiler/ProfilerSimple.php',
604604 'ProfilerSimpleText' => 'includes/profiler/ProfilerSimpleText.php',
 605+ 'ProfilerSimpleTrace' => 'includes/profiler/ProfilerSimpleTrace.php',
605606 'ProfilerSimpleUDP' => 'includes/profiler/ProfilerSimpleUDP.php',
606607 'ProfilerStub' => 'includes/profiler/ProfilerStub.php',
607608

Follow-up revisions

RevisionCommit summaryAuthorDate
r91758MFT to REL1_18:...hashar21:26, 8 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86633* Added Profiler::isStub() to check if we are using a stub profiler, instead ...ialex16:31, 21 April 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   18:16, 21 June 2011

Needs merge to 1.18 to fix r86633

Status & tagging log