r88204 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88203‎ | r88204 | r88205 >
Date:22:35, 15 May 2011
Author:wikinaut
Status:deferred
Tags:
Comment:
descriptionmsg typo fix; improving readme
Modified paths:
  • /trunk/extensions/OpenID/OpenID.i18n.php (modified) (history)
  • /trunk/extensions/OpenID/OpenID.setup.php (modified) (history)
  • /trunk/extensions/OpenID/README.OpenID-mediawiki-extension (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.i18n.php
@@ -31,8 +31,7 @@
3232 * @author Alexandre Emsenhuber
3333 */
3434 $messages['en'] = array(
35 - 'openid-desc' => 'Log in to the wiki with an [http://openid.net/ OpenID], and log in to other OpenID-aware web sites with a wiki user account',
36 -
 35+ 'openid-desc' => 'Lets users login to the wiki with an [http://openid.net/ OpenID] and login to other OpenID-aware Web sites with their wiki user account',
3736 'openidlogin' => 'Log in with OpenID',
3837 'openidserver' => 'OpenID server',
3938 'openidxrds' => 'Yadis file',
Index: trunk/extensions/OpenID/README.OpenID-mediawiki-extension
@@ -68,7 +68,7 @@
6969 turn depends on the OpenIDEnabled.com PHP library for YADIS. At the time of this
7070 writing, info on installing these libraries was available here:
7171
72 - http://www.openidenabled.com/php-openid/
 72+ http://www.openidenabled.com/php-openid/
7373
7474 Unfortunately, tt requires patches when running with PHP 5.3.x and later.
7575 The download from the above Url and the patch will be automatically done
@@ -340,7 +340,6 @@
341341 is for them.
342342
343343 * $wgOpenIDAllowServingOpenIDUserAccounts -- defaults to false.
344 -*
345344 Having this enabled, it allows to use Urls of this wiki's users' pages
346345 as OpenID identities on other OpenID-aware sites even when OpenID(s) are
347346 associated with user accounts on this wiki. Some users might want to do that
@@ -350,11 +349,10 @@
351350 on other sites.
352351
353352 Remark:
 353+ User page urls can (currently) only act as OpenID if the user page really
 354+ exists i.e. has content. The mere existence of a user account is (currently)
 355+ not sufficient.
354356
355 - User page urls can (currently) only act as OpenID if the User page is existing,
356 - i.e. has content, the mere existence of a user account is (currently) not
357 - sufficient.
358 -
359357 * $wgOpenIDShowProviderIcons -- defaults to false due to potential
360358 brand issues. With this enabled, users will see button graphics
361359 instead of just links in OpenID provider UI.
Index: trunk/extensions/OpenID/OpenID.setup.php
@@ -197,7 +197,7 @@
198198 'path' => __FILE__,
199199 'author' => array( 'Evan Prodromou', 'Sergey Chernyshev', 'Alexandre Emsenhuber', 'Thomas Gries' ),
200200 'url' => 'http://www.mediawiki.org/wiki/Extension:OpenID',
201 - 'descriptiomsg' => 'openid-desc',
 201+ 'descriptionmsg' => 'openid-desc',
202202 );
203203
204204 function OpenIDGetServerPath() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r88223Followup r88204: having the verb as 'log in' is clearernikerabbit10:08, 16 May 2011

Status & tagging log