r88193 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88192‎ | r88193 | r88194 >
Date:16:19, 15 May 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 26742) Add @noflip to RTL-specific rules in jquery.ui.datepicker.css
Modified paths:
  • /trunk/phase3/resources/jquery.ui/themes/default/jquery.ui.datepicker.css (modified) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.datepicker.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.datepicker.css
——@@ -35,17 +35,17 @@
3636 .ui-datepicker-row-break { clear:both; width:100%; }
3737
3838 /* RTL support */
39 -.ui-datepicker-rtl { direction: rtl; }
40 -.ui-datepicker-rtl .ui-datepicker-prev { right: 2px; left: auto; }
41 -.ui-datepicker-rtl .ui-datepicker-next { left: 2px; right: auto; }
42 -.ui-datepicker-rtl .ui-datepicker-prev:hover { right: 1px; left: auto; }
43 -.ui-datepicker-rtl .ui-datepicker-next:hover { left: 1px; right: auto; }
44 -.ui-datepicker-rtl .ui-datepicker-buttonpane { clear:right; }
45 -.ui-datepicker-rtl .ui-datepicker-buttonpane button { float: left; }
46 -.ui-datepicker-rtl .ui-datepicker-buttonpane button.ui-datepicker-current { float:right; }
47 -.ui-datepicker-rtl .ui-datepicker-group { float:right; }
48 -.ui-datepicker-rtl .ui-datepicker-group-last .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
49 -.ui-datepicker-rtl .ui-datepicker-group-middle .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
 39+/* @noflip */ .ui-datepicker-rtl { direction: rtl; }
 40+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-prev { right: 2px; left: auto; }
 41+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-next { left: 2px; right: auto; }
 42+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-prev:hover { right: 1px; left: auto; }
 43+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-next:hover { left: 1px; right: auto; }
 44+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-buttonpane { clear:right; }
 45+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-buttonpane button { float: left; }
 46+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-buttonpane button.ui-datepicker-current { float:right; }
 47+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-group { float:right; }
 48+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-group-last .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
 49+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-group-middle .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
5050
5151 /* IE6 IFRAME FIX (taken from datepicker 1.5.3 */
5252 .ui-datepicker-cover {
Index: trunk/phase3/resources/jquery.ui/themes/default/jquery.ui.datepicker.css
——@@ -35,17 +35,17 @@
3636 .ui-datepicker-row-break { clear:both; width:100%; }
3737
3838 /* RTL support */
39 -.ui-datepicker-rtl { direction: rtl; }
40 -.ui-datepicker-rtl .ui-datepicker-prev { right: 2px; left: auto; }
41 -.ui-datepicker-rtl .ui-datepicker-next { left: 2px; right: auto; }
42 -.ui-datepicker-rtl .ui-datepicker-prev:hover { right: 1px; left: auto; }
43 -.ui-datepicker-rtl .ui-datepicker-next:hover { left: 1px; right: auto; }
44 -.ui-datepicker-rtl .ui-datepicker-buttonpane { clear:right; }
45 -.ui-datepicker-rtl .ui-datepicker-buttonpane button { float: left; }
46 -.ui-datepicker-rtl .ui-datepicker-buttonpane button.ui-datepicker-current { float:right; }
47 -.ui-datepicker-rtl .ui-datepicker-group { float:right; }
48 -.ui-datepicker-rtl .ui-datepicker-group-last .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
49 -.ui-datepicker-rtl .ui-datepicker-group-middle .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
 39+/* @noflip */ .ui-datepicker-rtl { direction: rtl; }
 40+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-prev { right: 2px; left: auto; }
 41+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-next { left: 2px; right: auto; }
 42+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-prev:hover { right: 1px; left: auto; }
 43+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-next:hover { left: 1px; right: auto; }
 44+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-buttonpane { clear:right; }
 45+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-buttonpane button { float: left; }
 46+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-buttonpane button.ui-datepicker-current { float:right; }
 47+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-group { float:right; }
 48+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-group-last .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
 49+/* @noflip */ .ui-datepicker-rtl .ui-datepicker-group-middle .ui-datepicker-header { border-right-width:0; border-left-width:1px; }
5050
5151 /* IE6 IFRAME FIX (taken from datepicker 1.5.3 */
5252 .ui-datepicker-cover {

Comments

#Comment by Nikerabbit (talk | contribs)   10:00, 16 May 2011

Is this solution maintainable (enough)?

Status & tagging log