r88151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88150‎ | r88151 | r88152 >
Date:11:01, 15 May 2011
Author:erik
Status:ok (Comments)
Tags:
Comment:
Move to startup per r88146 code review comment
Modified paths:
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js (modified) (history)
  • /trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.js
@@ -310,9 +310,6 @@
311311 }
312312 };
313313
314 -// Do not show if we're viewing a redirect
315 -if(mw.util.getParamValue('redirect')=='no') return false;
316 -
317314 /* Load at the bottom of the article */
318315 var $aftDiv = $( '<div id="mw-articlefeedback"></div>' ).articleFeedback( config );
319316
Index: trunk/extensions/ArticleFeedback/modules/ext.articleFeedback/ext.articleFeedback.startup.js
@@ -13,6 +13,8 @@
1414 // Current revision
1515 && mw.util.getParamValue( 'diff' ) == null
1616 && mw.util.getParamValue( 'oldid' ) == null
 17+ // Not viewing a redirect
 18+ && mw.util.getParamValue( 'redirect' ) != 'no'
1719 ) {
1820 var trackingBucket = mw.user.bucket(
1921 'ext.articleFeedback-tracking', mw.config.get( 'wgArticleFeedbackTracking' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r893551.17wmf1: MFT r88146, r88151, r89198, r89274catrope18:54, 2 June 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88146Suppress article feedback tool on redirects. (Bug reported on English...erik10:41, 15 May 2011

Comments

#Comment by He7d3r (talk | contribs)   20:47, 27 May 2011

Could this be put live to avoid more problems like these?

#Comment by He7d3r (talk | contribs)   19:30, 30 May 2011

Will this fix be deployed together with the full deployment of Article Feedback planned for tomorrow?

The bug was mentioned again on this page.

Status & tagging log