r88139 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r88138‎ | r88139 | r88140 >
Date:09:54, 15 May 2011
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
Add 'hash' => array( 'class' => 'HashBagOStuff' ) to $wgObjectCaches; greatly speeds up importDump.php
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/DefaultSettings.php
——@@ -1537,6 +1537,7 @@
15381538 'xcache' => array( 'class' => 'XCacheBagOStuff' ),
15391539 'wincache' => array( 'class' => 'WinCacheBagOStuff' ),
15401540 'memcached-php' => array( 'class' => 'MemcachedPhpBagOStuff' ),
 1541+ 'hash' => array( 'class' => 'HashBagOStuff' ),
15411542 );
15421543
15431544 /**

Comments

#Comment by Hashar (talk | contribs)   17:02, 5 June 2011

Good catch, although the Hash caching will probably eat all available memory. You should really use APC.

#Comment by Bryan (talk | contribs)   17:53, 5 June 2011

There are as far as I know no binaries for APC for Windows. Also I'm not sure if it works in CLI mode.

#Comment by Hashar (talk | contribs)   18:35, 5 June 2011

Might want XCache so :)

#Comment by 😂 (talk | contribs)   18:36, 5 June 2011

Or WinCache :p

#Comment by Bryan (talk | contribs)   18:39, 5 June 2011

Doesn't work in CLI mode.

Status & tagging log