r88122 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r88121‎ | r88122 | r88123 >
Date:22:57, 14 May 2011
Author:emufarmers
Status:ok (Comments)
Tags:
Comment:
(bug 28287) The "your changes" box for edit conflicts is now read-only. Patch by MZMcBride.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -43,6 +43,7 @@
4444 * (bug 18803) JPEG2000 images can no longer be uploaded as JPEG image.
4545 * (bug 11868) If using links to count articles, the checking will now be based
4646 on the real presence of an internal link instead of the "[[" string
 47+* (bug 28287) The "your changes" box for edit conflicts is now read-only.
4748
4849 === API changes in 1.19 ===
4950 * (bug 27790) add query type for querymodules to action=paraminfo
Index: trunk/phase3/CREDITS
@@ -122,6 +122,7 @@
123123 * Mike Horvath
124124 * Mormegil
125125 * MrPete
 126+* MZMcBride
126127 * Nakon
127128 * Nathan Larson
128129 * nephele
Index: trunk/phase3/includes/EditPage.php
@@ -1740,7 +1740,7 @@
17411741 }
17421742
17431743 protected function showTextbox2() {
1744 - $this->showTextbox( $this->textbox2, 'wpTextbox2', array( 'tabindex' => 6 ) );
 1744+ $this->showTextbox( $this->textbox2, 'wpTextbox2', array( 'tabindex' => 6, 'readonly' ) );
17451745 }
17461746
17471747 protected function showTextbox( $content, $name, $customAttribs = array() ) {

Comments

#Comment by Hashar (talk | contribs)   00:21, 15 May 2011

I did not know it was editable!! Good catch MZMcBride!

#Comment by MZMcBride (talk | contribs)   19:27, 22 May 2011

Status & tagging log